Add Bfloat16 support - #361
Open
franz101 wants to merge 5 commits into
Open
Conversation
Author
|
@xzkostyan mind approving this? |
| def visit_float32(self, type_, **kw): | ||
| return 'Float32' | ||
|
|
||
| def visit_bfloat32(self, type_, **kw): |
There was a problem hiding this comment.
Hi @franz101, think you have a typo here:
Suggested change
| def visit_bfloat32(self, type_, **kw): | |
| def visit_bfloat16(self, type_, **kw): |
joe-clickhouse
approved these changes
Sep 25, 2025
joe-clickhouse
left a comment
joe-clickhouse
left a comment
There was a problem hiding this comment.
Aside from the typo, I think it looks good. One small thing to keep in mind is that as we introduce new types into this lib, it'll work fine with default http transport, but it will not work if using tcp via clickhouse-driver until the (de)serialization work is implemented over there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BFloat16 support for Clickhouse 24.12
#359